>> +#define FIRMWARE_ADDR 0x0
>> +
>> +static void write_boot_rom(DriveInfo *dinfo, hwaddr addr, size_t rom_size,
>> + Error **errp)
>> +{
>> + BlockBackend *blk = blk_by_legacy_dinfo(dinfo);
>> + uint8_t *storage;
>> +
>> + if (rom_size > blk_getlength(blk)) {
>> + rom_size = blk_getlength(blk);
>> + }
>> +
>> + storage = g_new0(uint8_t, rom_size);
>
> Hi -- coverity points out that you're not checking for the
> case where blk_getlength() returns negative. (This can happen
> for the case where the BlockBackend represents an insertable
> device like a floppy or cdrom with no medium present.)
>
> Since for aspeed this dinfo always represents a flash device,
> we know this shouldn't happen, so you can just make it a fatal
> error if blk_getlength() doesn't return what you're expecting.
OK. I will send a fix to improve this routine.
Thanks,
C.
