On 25 January 2017 at 18:27, <no-re...@patchew.org> wrote: > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility > of usb-tablet > Message-id: 1485365075-32702-1-git-send-email-p...@philjordan.eu > > === OUTPUT BEGIN === > Checking PATCH 1/1: hw/usb/dev-hid: Improve guest compatibility of > usb-tablet... > ERROR: code indent should never use tabs > #43: FILE: hw/usb/dev-hid.c:490: > + 0x09, 0x02,^I^I/* Usage (Mouse) */$
Interestingly, the surrounding array initialisation already uses tabs, so replacing them with spaces on only the line I edited seems wrong as it'll mis-render in editors configured with a different tab width. Please let me know if I need to take action on this issue, and if so what to do. (I can add a whitespace-only patch to fix the surrounding area, for example. Coding guidelines suggest this might not be desirable though.)
