On Tue, Jan 24, 2017 at 07:18:14PM +0100, Paolo Bonzini wrote: > > > On 17/01/2017 17:01, Michael S. Tsirkin wrote: > >>> Doesn't do it for megasas & hcd-xhci, later patches will fix them. > >>> > >>> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> > > I don't like this one, frankly. That's a bunch of code duplication. > > I suspect vfio is the only one who might reasonably get EINVAL here. > > So how about e.g. msix_validate_and_init that doesn't assert and use that > > from vfio, then switch msix_init to assert instead? > > The names we use normally would be msix_init and msix_init_nofail. > Would still require a change through the whole tree, but it's more > consistent at least. > > Paolo
This area has seen too much noise already but OK I guess. Also, msix_init_exclusive_bar probably should assert internally, no need for two versions. -- MST
