On Mon, Sep 20, 2010 at 9:36 AM, Michal Novotny <minov...@redhat.com> wrote: > Hi, > there were compilation errors when I was trying to compile i386-softmmu > target on i386 > host (running on Fedora-13 with development version of qemu downloaded from > git). > > There were errors of comparison of unsigned expression was always true which > made it > unable to compile. This simple fix fixes the issue. > > ... > cc1: warnings being treated as errors > .../hw/vhost_net.c: In function ‘vhost_net_start’: > .../vhost_net.c:154: error: comparison of unsigned expression >= 0 is always > true > make[1]: *** [vhost_net.o] Error 1 > make: *** [subdir-i386-softmmu] Error 2 > > Signed-off-by: Michal Novotny <minov...@redhat.com>
I don't think the patch is correct. It looks like zero is a valid value for file.index, changing the check means that the ioctl is not performed for case file.index == 0. The preincrements and predecrements seem suspicious.
