On 9 January 2017 at 16:24, Cédric Le Goater <c...@kaod.org> wrote: > The Aspeed SMC controllers have a mode (Command mode) in which > accesses to the flash content are no different than doing MMIOs. The > controller generates all the necessary commands to load (or store) > data in memory. > > However, accesses are restricted to the segment window assigned the > the flash module by the controller. This window is defined by the > Segment Address Register. > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > Reviewed-by: Andrew Jeffery <and...@aj.id.au> > --- > hw/ssi/aspeed_smc.c | 152 > ++++++++++++++++++++++++++++++++++++++------ > include/hw/ssi/aspeed_smc.h | 2 +- > 2 files changed, 132 insertions(+), 22 deletions(-)
This deleted the only call to aspeed_smc_is_usermode() but not its definition, which makes clang complain: /Users/pm215/src/qemu-for-merges/hw/ssi/aspeed_smc.c:409:20: error: unused function 'aspeed_smc_is_usermode' [-Werror,-Wunused-function] Presumably the function itself should be deleted? thanks -- PMM
