On Mon, Sep 20, 2010 at 10:42:31AM +0200, Kevin Wolf wrote: > Am 18.09.2010 23:12, schrieb Stefan Hajnoczi: > > On Sat, Sep 18, 2010 at 9:57 PM, Hervé Poussineau <hpous...@reactos.org> > > wrote: > >> Another patch creating ARP replies at least 64 bytes long has been > >> committed: > >> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=dbf3c4b4baceb91eb64d09f787cbe92d65188813 > >> > >> Does it fix your issue? > > > > No I don't think so. This is an e1000 issue, it will happen if you > > use tap networking too. The commit you linked to only affects slirp > > and pads its ARP code. > > > > I think there are two places where the minimum frame length can be enforced: > > 1. The NIC emulation code. This is currently how rtl8139, pcnet, and > > ne2000 do it. My patch adds the same for e1000. > > 2. The net layer. If we're emulating Ethernet then it would be > > possible to pad to minimum frame length in common networking code > > (net.c). > > 3. The sender. I think it should be the sender's decision which packet > he sends and there's no reason to manipulate it on its way to the guest. > If the sender sends too short packets, this is where the bug is.
Yes, but when using tap, the ethernet sender is QEMU itself. Tap doesn't have the same requirements as ethernet so the original sender has no reason to pad. Internally in QEMU, there is code that picks up tap packets and forwards them to the emulated ethernet links, this is were padding should be done IMO. Not in the device models receive path. The bridge that forwards frames from tap into emulated links must also handle different kinds of link types, as all emulated network devices are not necessarily ethernet. Cheers -- emulated netcards don't work with recent sunos kernel https://bugs.launchpad.net/bugs/638955 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: hi there, i'm using qemu-kvm backend in version: # qemu-kvm -version QEMU PC emulator version 0.12.5 (qemu-kvm-0.12.5), Copyright (c) 2003-2008 Fabrice Bellard and there are just *not working any of model=$type with combinations of recent sunos (solaris, openindiana, opensolaris, ..) .. you can download for testing purposes iso from here: http://dlc-origin.openindiana.org/isos/147/ or from here: http://genunix.org/distributions/indiana/ << osol and oi are also bubuntu-like *live cds, so no need to bother with installing behaviour is as follows: e1000 - receiving doesn't work, transmitting works .. dladm (tool for handle ethers) shows that is all ok, correct mode is loaded up, it just seems like this driver works at 100% but .. rtl8169|pcnet - works in 10Mbit mode with several other issues like high cpu utilization and so .. dladm is unable to recognize options for this kind of -nic others - just don't work .. i experienced this issue several times in past .. woraround was, that rtl8169 worked so-so .. with recent sunos kernel it doesn't. it's easy to reproduce, this is why i'm not putting here more then launching script for my virtual machine: # cat openindiana.sh qemu-kvm -hda /home/kvm/openindiana/openindiana.img -m 2048 -localtime -cdrom /home/kvm/+images/oi-dev-147-x86.iso -boot d \ -vga std -vnc :9 -k en-us -monitor unix:/home/kvm/openindiana/instance,server,nowait \ -net nic,model=e1000,vlan=1 -net tap,ifname=oi0,script=no,vlan=1 & sleep 2; ip l set oi0 up; ip a a 192.168.99.9/24 dev oi0; regards by daniel
