Am 19.09.2010 08:36, schrieb Stefan Hajnoczi: > On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias > <edgar.igles...@gmail.com> wrote: >> This doesn't look right. AFAIK, MAC's dont pad on receive. > > I agree. NICs that do padding will do it on transmit, not receive. > Anything coming in on the wire should already have the minimum length. > > In QEMU that isn't true today and that's why rtl8139, pcnet, and > ne2000 already do this same padding. This patch is the smallest > change to cover e1000.
What's the reason that it isn't true in QEMU today? Shouldn't we fix these problems rather than making device emulations incorrect to compensate for it? Kevin
