On Tue, Jan 17, 2017 at 11:52:24AM +0000, Peter Maydell wrote: > On 12 January 2017 at 14:28, Julian Brown <jul...@codesourcery.com> wrote: > > On Wed, 11 Jan 2017 12:35:52 +0000 > > Julian Brown <jul...@codesourcery.com> wrote: > > > >> I'm a little confused, I think -- these changes seemed to be necessary > >> to allow the parsing of the command-line syntax you suggested earlier > >> (-mcpu=foo,cfgend=bar): > >> [...] > >> Can the existing properties be set like that via the command line? > > > > Aha! The answer was yes, but only currently for the "virt" board > > (which we haven't been using for aarch32, and only supports a few recent > > CPU types at present). I'm less confused now! (The string-splitting code > > in arm_cpu_class_by_name is still dubious though, IMO.) > > Oops, I'd forgotten there was board-specific code for handling > cpu feature flags. I think we want to change the other boards > to do it like the virt board does, but maybe I'm wrong. > I've cc'd Eduardo who will hopefully know the right way to handle > this.
I don't understand what's missing here: cpu_arm_init() already calls cpu_generic_init(), which already calls CPUClass::parse_features() after splitting the cpu_model string and calling CPUClass::class_by_name(). Which board aree you using to test this? Is the board calling cpu_arm_init() to create the CPU? -- Eduardo
