On 17 January 2017 at 08:20, Gerd Hoffmann <kra...@redhat.com> wrote: > On Mo, 2017-01-16 at 18:35 +0000, Peter Maydell wrote: >> On 11 January 2017 at 10:58, Gerd Hoffmann <kra...@redhat.com> wrote: >> > No need to go the indirect route with a bitfield and mapping the bits to >> > INPUT_BUTTON_*. We can use a bool array and INPUT_BUTTON_* directly >> > instead. >> > >> > Untested, not even compiled, due to lack of a osx^Wmacos machine. >> > Test results are very welcome. >> >> So what does the patch gain us? > > I can drop MOUSE_EVENT_WHEEL* without breaking the osx build.
Why do you want to drop it, though? It's a valid mouse event type, and you're not going to drop the whole MOUSE_EVENT_* set of defines, I assume, because they're used in lots of devices. >> We'll now loop round >> that button array for every event rather than only >> the ones where the button state changed, > > Well, we loop round anyway, you just don't see it directly b/c it is > hidden in the qemu_input_update_buttons() helper function. No, we only call qemu_input_update_buttons() if last_buttons != buttons. thanks -- PMM
