On 2017年01月13日 11:06, Peter Xu wrote:
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do it. Generally, the rule of mine is: - for the old GENERAL typed message, I use error_report() directly if apply. Those are something shouldn't happen, and we should print those errors in all cases, even without enabling debug and tracing.
Looks like some were guest trigger-able. If yes, let's try not use error_report() for not being flooded.
Thanks
- for the non-GENERAL typed messages, remove those VTD_PRINTF()s that looks hardly used, and convert the rest lines into trace_*(). - for useless DPRINTFs, I removed them.
