Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1483568308-28868-1-git-send-email-nutar...@ornl.gov
Subject: [Qemu-devel] [PATCH v5] qqq: module for synchronizing with a simulation

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1483568308-28868-1-git-send-email-nutar...@ornl.gov -> 
patchew/1483568308-28868-1-git-send-email-nutar...@ornl.gov
Switched to a new branch 'test'
02ad2a8 qqq: module for synchronizing with a simulation

=== OUTPUT BEGIN ===
Checking PATCH 1/1: qqq: module for synchronizing with a simulation...
ERROR: do not use C99 // comments
#195: FILE: qqq.c:17:
+static unsigned elapsed; // This must be zero on initialization

ERROR: trailing whitespace
#234: FILE: qqq.c:56:
+        /* Setting syncing to false tells kvm-all that $

ERROR: code indent should never use tabs
#241: FILE: qqq.c:63:
+^I^I/* Restart the emulator clock */$

ERROR: braces {} are necessary for all arms of this statement
#288: FILE: qqq.c:110:
+    if (time_advance < 0)
[...]

WARNING: line over 80 characters
#291: FILE: qqq.c:113:
+    assert(t == 0 || abs(t - qemu_clock_get_us(QEMU_CLOCK_VIRTUAL) <= 
time_advance));

total: 4 errors, 1 warnings, 405 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

Reply via email to