On Sun, Sep 12, 2010 at 10:42 PM, Christoph Hellwig <[email protected]> wrote: > Use qemu_blockalign for all allocations in the block layer. This allows > increasing the required alignment, which is need to support O_DIRECT on > devices with large block sizes. > > Signed-off-by: Christoph Hellwig <[email protected]>
I noticed that the backing file may have different alignment requirements than the image file but qemu_blockalign() currently only takes into account the image file's requirements. Not necessarily something for this patch, but since you're in the area I wanted to mention it. It seems safe to take the max alignment (they should both be powers of two I think) of the image and backing files. Stefan
