On Wed, Sep 08, 2010 at 04:39:35PM +0900, Isaku Yamahata wrote: > +#define PCI_EXP_SLTCTL_AIC_SHIFT 6 > +#define PCI_EXP_SLTCTL_AIC_ON (PCI_EXP_HP_IND_ON << > PCI_EXP_SLTCTL_AIC_SHIFT) > +#define PCI_EXP_SLTCTL_AIC_BLINK (PCI_EXP_HP_IND_BLINK << > PCI_EXP_SLTCTL_AIC_SHIFT) > +#define PCI_EXP_SLTCTL_AIC_OFF (PCI_EXP_HP_IND_OFF << > PCI_EXP_SLTCTL_AIC_SHIFT) > + > +#define PCI_EXP_SLTCTL_PIC_SHIFT 8 > +#define PCI_EXP_SLTCTL_PIC_ON (PCI_EXP_HP_IND_ON << > PCI_EXP_SLTCTL_PIC_SHIFT) > +#define PCI_EXP_SLTCTL_PIC_BLINK (PCI_EXP_HP_IND_BLINK << > PCI_EXP_SLTCTL_PIC_SHIFT) > +#define PCI_EXP_SLTCTL_PIC_OFF (PCI_EXP_HP_IND_OFF << > PCI_EXP_SLTCTL_PIC_SHIFT)
It might be better to simply define the 6 macros we are using directly. The duplication here is minimal, and I guess it will be easier get them into linux this way. -- MST
