On 12/14/2016 06:12 PM, Peter Maydell wrote: > On 29 November 2016 at 15:43, Cédric Le Goater <c...@kaod.org> wrote: >> Here is a collection of fixes and improvements on existing models for >> the Aspeed SoCs > > I have taken into target-arm.next for 2.9 patches 2-13: > >> m25p80: add support for the mx66l1g45g >> aspeed: QOMify the CPU object and attach it to the SoC >> aspeed: remove cannot_destroy_with_object_finalize_yet >> aspeed: attach the second SPI controller object to the SoC >> aspeed: extend the board configuration with flash models >> aspeed: add support for the romulus-bmc board >> aspeed: add a memory region for SRAM >> aspeed: add the definitions for the AST2400 A1 SoC >> aspeed: change SoC revision of the palmetto-bmc machine >> aspeed/scu: fix SCU region size >> aspeed/smc: improve segment register support >> aspeed/smc: set the number of flash modules for the FMC controller > > which should at least reduce the size of this patchset for the > next round.
Thanks a lot, I was going to ask you that :) I think I can simplify easily the vbar patch with the input you just gave. I lost my way with the EL3 I guess. The model option to the drive should be just dropped. However, using -drive / -device to define the flash modules on the command line introduces more changes as we need to take them into account at reset time and not at init time anymore. I need to think about it. Marcin had some concerns on the way the patchset handles the command mode modeling of the SMC controller. It can be improved surely but I won't do that right now. So that's a couple of patches for later. I will take a look at the crash you spotted. Funny that I did not see that. The watchdog needs some review. It is nice to have as it gives Linux reboot. Alastair has an interesting RTC device we could plug on the palmetto machine. I have a little TMP421 device on the waiting stack after. Thanks, C.
