On 14/12/2016 08:59, Thomas Huth wrote: >>> Right, good catch, thanks! Looks like I did it right in the other >>> patches and used target/ppc/cpu.h there for example ... I'll fix it for >>> ARM in the next version of the patch... >> There is the same problem in: m68k, alpha, mips and sh4. >> >> Could you fix them too? > You mean the #inlcude "cpu-qom.h" statements? I think they are less > critical since there is no cpu-qom.h in the generic include folder ... > but yes, better safe than sorry, I'll fix these statements, too.
There is no cpu.h either in include/. The only path added is include/, not include/migration/ or include/qom/, so "cpu.h" can only come from targets. "git grep include.*cpu.h hw" shows that a wide majority of inclusions (120 against 9, many of which in hw/arm) doesn't prepend target-foo/. So the patch looks good to me. Paolo
