Hi On Tue, Dec 13, 2016 at 2:18 PM Paolo Bonzini <pbonz...@redhat.com> wrote:
> > > On 12/12/2016 23:43, Marc-André Lureau wrote: > > This will help to split char.c in several units without having to > > reference them all everywhere. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > Makefile | 3 ++- > > Makefile.objs | 4 +++- > > Makefile.target | 3 +++ > > chardev/Makefile.objs | 2 +- > > tests/Makefile.include | 4 ++-- > > 5 files changed, 11 insertions(+), 5 deletions(-) > > Any reason to do this instead of keeping common-obj-y? > > common-obj-y has a lot of other units, including vl.o, making it not possible to link with tests/test-char for ex. However, if we changed it to link with everything except vl.c (or other changes), we may be able to link with and test spice-qemu-char. The resulting binaries will likely explode though. Thanks, > > Paolo > > -- Marc-André Lureau
