Hi, Your series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines' Type: series Message-id: 1479777133-23567-1-git-send-email-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1479777133-23567-1-git-send-email-ehabk...@redhat.com -> patchew/1479777133-23567-1-git-send-email-ehabk...@redhat.com Switched to a new branch 'test' 5e1ecf3 qdev: Add device_class_set_bus_type() function c8ab7cb ppc: Initialize default bus lists 70590aa mips: Initialize default bus lists 896edc8 arm: Initialize default bus lists dd993a8 s390x: Initialize default bus lists 9ef506f pc: Initialize default bus lists 24f4450 pci: Introduce INTERFACE_PCIE_DEVICE interface name c39bfeb qmp: Add 'supported-device-types' field to 'query-machines' 07ce179 machine: Add MachineClass::default_buses field 7680d6c qdev: Add device_type field to BusClass 76da7a3 tests: Add rules to non-gtester qtest test cases e531dad qtest.py: Make 'binary' parameter optional 80780b6 qtest.py: make logging optional 3d3c3e5 qtest.py: Support QTEST_LOG environment variable b2326ca qemu.py: Make logging optional === OUTPUT BEGIN === Checking PATCH 1/15: qemu.py: Make logging optional... Checking PATCH 2/15: qtest.py: Support QTEST_LOG environment variable... Checking PATCH 3/15: qtest.py: make logging optional... WARNING: line over 80 characters #26: FILE: scripts/qtest.py:87: + socket_scm_helper=socket_scm_helper, total: 0 errors, 1 warnings, 14 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/15: qtest.py: Make 'binary' parameter optional... Checking PATCH 5/15: tests: Add rules to non-gtester qtest test cases... Checking PATCH 6/15: qdev: Add device_type field to BusClass... Checking PATCH 7/15: machine: Add MachineClass::default_buses field... Checking PATCH 8/15: qmp: Add 'supported-device-types' field to 'query-machines'... WARNING: line over 80 characters #111: FILE: tests/qmp-machine-info.py:39: + dt = vm.qmp('qom-get', path=cp, property='device-type')['return'] ERROR: line over 90 characters #119: FILE: tests/qmp-machine-info.py:47: + vm = qtest.QEMUQtestMachine(args=['-S', '-machine', machine['name']], logging=False) WARNING: line over 80 characters #141: FILE: tests/qmp-machine-info.py:69: + self.fail("extra device types: %s" % (' '.join(missing_types))) WARNING: line over 80 characters #162: FILE: tests/qmp-machine-info.py:90: + vm = qtest.QEMUQtestMachine(args=['-S', '-machine', 'none'], logging=False) total: 1 errors, 3 warnings, 189 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/15: pci: Introduce INTERFACE_PCIE_DEVICE interface name... Checking PATCH 10/15: pc: Initialize default bus lists... ERROR: do not use C99 // comments #20: FILE: hw/i386/pc_piix.c:438: + machine_class_add_default_bus(m, "floppy-bus"); //FIXME: use macro ERROR: do not use C99 // comments #21: FILE: hw/i386/pc_piix.c:439: + machine_class_add_default_bus(m, "i2c-bus"); //FIXME: use macro ERROR: do not use C99 // comments #24: FILE: hw/i386/pc_piix.c:442: + machine_class_add_default_bus(m, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #32: FILE: hw/i386/pc_piix.c:1087: + machine_class_add_default_bus(m, "floppy-bus"); //FIXME: use macro ERROR: do not use C99 // comments #34: FILE: hw/i386/pc_piix.c:1089: + machine_class_add_default_bus(m, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #42: FILE: hw/i386/pc_piix.c:1109: + machine_class_add_default_bus(m, "floppy-bus"); //FIXME: use macro ERROR: do not use C99 // comments #43: FILE: hw/i386/pc_piix.c:1110: + machine_class_add_default_bus(m, "i2c-bus"); //FIXME: use macro ERROR: do not use C99 // comments #46: FILE: hw/i386/pc_piix.c:1113: + machine_class_add_default_bus(m, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #58: FILE: hw/i386/pc_q35.c:295: + machine_class_add_default_bus(m, "i2c-bus"); //FIXME: use macro ERROR: do not use C99 // comments #61: FILE: hw/i386/pc_q35.c:298: + machine_class_add_default_bus(m, "IDE");//FIXME: use macro total: 10 errors, 0 warnings, 49 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/15: s390x: Initialize default bus lists... Checking PATCH 12/15: arm: Initialize default bus lists... ERROR: do not use C99 // comments #29: FILE: hw/arm/aspeed.c:183: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #30: FILE: hw/arm/aspeed.c:184: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #42: FILE: hw/arm/collie.c:67: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #54: FILE: hw/arm/cubieboard.c:85: + machine_class_add_default_bus(mc, TYPE_IDE_BUS);//FIXME: use macro ERROR: do not use C99 // comments #74: FILE: hw/arm/exynos4_boards.c:158: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #83: FILE: hw/arm/exynos4_boards.c:175: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #104: FILE: hw/arm/gumstix.c:132: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #106: FILE: hw/arm/gumstix.c:134: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #114: FILE: hw/arm/gumstix.c:149: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #116: FILE: hw/arm/gumstix.c:151: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #128: FILE: hw/arm/highbank.c:410: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #129: FILE: hw/arm/highbank.c:411: + machine_class_add_default_bus(mc, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #137: FILE: hw/arm/highbank.c:428: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #138: FILE: hw/arm/highbank.c:429: + machine_class_add_default_bus(mc, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #150: FILE: hw/arm/imx25_pdk.c:151: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #162: FILE: hw/arm/kzm.c:145: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #174: FILE: hw/arm/musicpal.c:1722: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #186: FILE: hw/arm/nseries.c:1428: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #194: FILE: hw/arm/nseries.c:1444: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #206: FILE: hw/arm/palm.c:278: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #218: FILE: hw/arm/realview.c:448: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #238: FILE: hw/arm/spitz.c:988: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #240: FILE: hw/arm/spitz.c:990: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #248: FILE: hw/arm/spitz.c:1005: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #250: FILE: hw/arm/spitz.c:1007: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #258: FILE: hw/arm/spitz.c:1022: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #260: FILE: hw/arm/spitz.c:1024: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #272: FILE: hw/arm/stellaris.c:1396: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #273: FILE: hw/arm/stellaris.c:1397: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro ERROR: do not use C99 // comments #281: FILE: hw/arm/stellaris.c:1412: + machine_class_add_default_bus(mc, "SSI");//FIXME: use macro ERROR: do not use C99 // comments #282: FILE: hw/arm/stellaris.c:1413: + machine_class_add_default_bus(mc, "i2c-bus");//FIXME: use macro total: 31 errors, 0 warnings, 185 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/15: mips: Initialize default bus lists... ERROR: do not use C99 // comments #31: FILE: hw/mips/mips_malta.c:1270: + machine_class_add_default_bus(mc, "floppy-bus"); //FIXME: use macro ERROR: do not use C99 // comments #32: FILE: hw/mips/mips_malta.c:1271: + machine_class_add_default_bus(mc, "i2c-bus"); //FIXME: use macro ERROR: do not use C99 // comments #35: FILE: hw/mips/mips_malta.c:1274: + machine_class_add_default_bus(mc, "IDE");//FIXME: use macro ERROR: do not use C99 // comments #49: FILE: hw/mips/mips_r4k.c:310: + machine_class_add_default_bus(mc, "IDE");//FIXME: use macro total: 4 errors, 0 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/15: ppc: Initialize default bus lists... ERROR: do not use C99 // comments #109: FILE: hw/ppc/prep.c:678: + machine_class_add_default_bus(mc, "floppy-bus"); //FIXME: use macro ERROR: do not use C99 // comments #112: FILE: hw/ppc/prep.c:681: + machine_class_add_default_bus(mc, "IDE");//FIXME: use macro total: 2 errors, 0 warnings, 67 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/15: qdev: Add device_class_set_bus_type() function... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org