On 11/17/2016 05:19 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> Use blkdebug's new geometry constraints to emulate setups that >> have caused recent regression fixes: write zeroes asserting >> when running through a loopback block device with max-transfer >> smaller than cluster size, and discard rounding away requests >> that were not aligned to power-of-two boundaries. Also, add >> coverage that the block layer is honoring max transfer limits. >>
>> +function verify_io()
>> +{
>> + if ($QEMU_IMG info -f "$IMGFMT" "$TEST_IMG" |
>> + grep "compat: 0.10" > /dev/null); then
>> + # For v2 images, discarded clusters are read from the backing file
>> + discarded=11
>> + else
>> + # Discarded clusters are zeroed for v3 or later
>> + discarded=0
>> + fi
>
> This is fine since you've already done the work to support compat=0.10,
> but I think we've had v3 long enough that you could have just put
> compat=0.10 into _unsupported_imgopts.
Copy-and-paste from 46, so it wasn't really that hard.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
