While working on the qdev class properteis series, I've noticed that the release function for class properties is never called, and have unclear semantics (should it be called when the object is destroyed, or when the class is destroyed?). Patch 1/1 removes the unused feature.
Patch 2/2 changes the function signature of qdev property release functions to make their implementations simpler and safer, and make them not depend on the way property release functions are implemented (so the functions don't need to be rewritten if we change qdev to use class properties). Eduardo Habkost (2): qom: Remove release function from class properties qdev: Change signature of PropertyInfo::release backends/hostmem.c | 4 ++-- hw/core/machine.c | 6 +++--- hw/core/qdev-properties-system.c | 8 ++------ hw/core/qdev-properties.c | 10 +++++----- hw/core/qdev.c | 10 +++++++++- hw/i386/pc.c | 8 ++++---- hw/ppc/pnv.c | 2 +- include/hw/qdev-core.h | 2 +- include/qom/object.h | 1 - qom/object.c | 14 ++++---------- 10 files changed, 31 insertions(+), 34 deletions(-) -- 2.7.4
