On 11/09/2016 03:57 PM, Alex Bennée wrote:
+#ifdef CONFIG_SOFTMMU + memset(env, 0, offsetof(CPUARMState, tlb_table)); + tlb_flush(s, 0); +#else memset(env, 0, offsetof(CPUARMState, features)); +#endif
I'd really prefer to see the tlb_flush be moved into parent_reset, so that we handle it identically for all targets.
As for the memset, do we really need to distinguish softmmu? I don't like you picking out a variable name within CPU_COMMON. Better to use empty struct markers, like the
struct {} start_init_save; that x86 uses. r~