On Wed 09 Nov 2016 10:50:40 AM CET, Pradeep Jagadeesh wrote:

> Uses throttling APIs to limit I/O bandwidth and number of operations
> on the devices which use 9p-local driver.
>
> Signed-off-by: Pradeep Jagadeesh <[email protected]>

It looks good now, thanks!

> +void fsdev_throttle_parse_opts(QemuOpts *opts, FsThrottle *fst, Error **err)
> +{
   [...]
> +    throttle_is_valid(&fst->cfg, err);
> +}

Following the QEMU conventions, I would still rename 'err' to 'errp' in
this function (since it's an Error **).

Otherwise,

Reviewed-by: Alberto Garcia <[email protected]>

Berto

Reply via email to