On Sat, Nov 05, 2016 at 12:03:15AM +0100, Kevin Wolf wrote: > Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if > the image hasn't been dirtied since the last flush. This is not quite > correct: The condition should be that the image hasn't been dirtied > since the last _successful_ flush. This patch changes the logic > accordingly. > > Without this fix, subsequent bdrv_co_flush() calls would return success > without actually doing anything even though the image is still dirty. > The difference is visible in some blkdebug test cases where error > messages incorrectly disappeared after commit 3ff2f67a. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/io.c | 4 +++- > tests/qemu-iotests/026.out | 22 ++++++++++++++++++++++ > tests/qemu-iotests/026.out.nocache | 22 ++++++++++++++++++++++ > tests/qemu-iotests/071.out | 2 ++ > 4 files changed, 49 insertions(+), 1 deletion(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
signature.asc
Description: PGP signature
