On 07/11/16 15:17, Sandra Loosemore wrote: > On 11/06/2016 08:55 PM, Guenter Roeck wrote: >> On Tue, Oct 18, 2016 at 11:50:25PM +0200, Marek Vasut wrote: >>> Add nios2 disassembler support. This patch is composed from binutils files >>> from commit "Opcodes and assembler support for Nios II R2". The files from >>> binutils used in this patch are: >>> >>> include/opcode/nios2.h >>> include/opcode/nios2r1.h >>> include/opcode/nios2r2.h >>> opcodes/nios2-opc.c >>> opcodes/nios2-dis.c >>> >>> Signed-off-by: Marek Vasut <ma...@denx.de> >>> Cc: Chris Wulff <crwu...@gmail.com> >>> Cc: Jeff Da Silva <jdasi...@altera.com> >>> Cc: Ley Foon Tan <lf...@altera.com> >>> Cc: Sandra Loosemore <san...@codesourcery.com> >>> Cc: Yves Vandervennet <yvand...@altera.com> >>> --- >>> V3: No change >>> V2: Replace the nios2.c with GPL2 licensed version >> >> checkpatch.pl reports: >> >> total: 1967 errors, 150 warnings, 3559 lines checked >> >> on this file. When applying it, git reports a number of whitespace problems. >> >> Is that expected ? >> >> Guenter > > I don't know what checkpatch.pl is, or what "errors" it might be > complaining about, but I'd strongly discourage doing anything to this code > that would cause it to diverge from the binutils code it was derived from, > even trivial whitespace changes.
./scripts/checkpatch.pl in the QEMU source tree. Reports about coding style problems (which can be ignored in the case like this, yes). > That would only complicate propagating > updates to the code to both components. (I can't say I have any such > patches in my queue right now, but I also can't rule out such changes in > the future....) Then why merging a bunch of files into a single one? If you ever do updates, it will be easier just to copy new files over and make a patch. > > -Sandra the nios2 binutils maintainer > > -- Alexey
