Michael Tokarev <m...@tls.msk.ru> writes: > 03.11.2016 08:56, Wang Xin wrote: >> qemu_find_file do not check file is a directory or just a file. >> If qemu start with "-k ''", qemu_find_file get a empty string >> as keymap file name, then, qemu treat the keymap path as keymap >> file, it makes vnc keyboard input unusable. > > Do we really care? "Garbage in, garbage out" I'd say :)
Moreover, are you really, really sure qemu_find_file() is never used to find a directory? Outside the scope of the patch: qemu_find_file() is basically a bad idea. By the time the file name it computes gets used, the file it found may be gone, or have become a directory (TOCTTOU). The proper fix for -k '' breaking the keyboard would be to make -k reject garbage input. Have a look at parse_keyboard_layout() and weep.
