I have submitted v3 with the QAPI schema changes. Regards, Ashish
On Thu, Oct 27, 2016 at 2:38 AM, ashish mittal <ashmit...@gmail.com> wrote: > Hi Daniel, > >>> >I think this version still does not address Daniel's concerns regarding a >>> >QAPI schema for vxhs. >>> >>> We are working on QAPI schema changes and will submit them in separate >>> patch. >> >> They should be part of the main patch, not a separate patch as they are >> a pre-requisite for any new block driver. >> > > I guess what Madhav meant was that this patch (v2) is missing the QAPI > changes, and we will provide those in the next version ASAP. > > Regards, > Ashish > > On Thu, Oct 27, 2016 at 12:29 AM, Daniel P. Berrange > <berra...@redhat.com> wrote: >> On Wed, Oct 26, 2016 at 03:23:05PM -0700, Ashish Mittal wrote: >>> This patch adds support for a new block device type called "vxhs". >>> Source code for the library that this code loads can be downloaded from: >>> https://github.com/MittalAshish/libqnio.git >>> >>> Sample command line using JSON syntax: >>> ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us >>> -vga cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg >>> timestamp=on >>> 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb387410}","server":[{"host":"172.172.17.4","port":"9999"}]}' >>> >>> Sample command line using URI syntax: >>> qemu-img convert -f raw -O raw -n >>> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad >>> vxhs://192.168.0.1:9999/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D >>> >>> Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> >>> --- >>> v2 changelog: >>> (1) Changes done in response to v1 comments. >> >> Yet again you've ignored the request to include the QAPI schema changes >> >>> block/Makefile.objs | 2 + >>> block/trace-events | 22 ++ >>> block/vxhs.c | 682 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> configure | 41 ++++ >>> 4 files changed, 747 insertions(+) >>> create mode 100644 block/vxhs.c >> >> Regards, >> Daniel >> -- >> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| >> |: http://libvirt.org -o- http://virt-manager.org :| >> |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
