On 2016/10/26 21:42, Eric Blake wrote:
On 10/26/2016 01:07 AM, Amit Shah wrote:
On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote:
configure --enable-colo/--disable-colo to switch COLO
support on/off.
COLO feature is enabled by default.
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Reviewed-by: Amit Shah <amit.s...@redhat.com>
v19:
- fix colo_supported() to return true
v11:
- Turn COLO on in default (Eric's suggestion)
Can you recap why the suggestion was made to switch it on by default?
If the feature doesn't depend on external libraries, then enabling
compilation by default will avoid bitrot.
I agreed.
But mentioning this rationale in the commit message never hurts :)
Good idea, i'll add this instruction in commit message.
Thank you very much for your speedy reply. :)
