On Sat, Oct 15, 2016 at 12:52:47AM +0200, Laurent Vivier wrote: > Put in cpu_exec_initfn() what initializes the CPU, > and let in cpu_exec_init() what adds it to the environment. > > As cpu_exec_initfn() is called by all XX_cpu_initfn() call it > directly in cpu_common_initfn(). > cpu_exec_init() is now a realize function, it will be renamed > to cpu_exec_realizefn() and moved to the XX_cpu_realizefn() > function in a following patch. > > Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Confirmed that: * cpu->num_ases and cpu->as are never changed by architecture code before calling cpu_exec_init() * cpu_exec_exit() is called on cpu_common_finalize() * The cpu->memory reference will be dropped automatically because the property is registered using OBJ_PROP_LINK_UNREF_ON_RELEASE BTW, the cpu->as and cpu->num_ases lines are redundant, because QOM objects are guaranteed to be zeroed when allocated. Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo