On Thu, Oct 13, 2016 at 08:29:30PM +0200, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > > I had problems with a build directory of the form "host,variant". > Is this fix needed for stable, too? > > Regards > Stefan W. > > scripts/tracetool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/tracetool.py b/scripts/tracetool.py > index 629b259..fe9c9e9 100755 > --- a/scripts/tracetool.py > +++ b/scripts/tracetool.py > @@ -70,7 +70,7 @@ def make_group_name(filename): > > if dirname == "": > return "common" > - return re.sub(r"/|-", "_", dirname) > + return re.sub(r"[^A-Za-z0-9]", "_", dirname)
dirname should only contain QEMU source tree subdirectory paths (e.g. hw/net). How did you get a comma in there? I tried an out-of-tree build in a directory called 'a,b' but it doesn't trigger the issue. I'd like to understand how to reproduce the problem in case I missed something. Stefan
signature.asc
Description: PGP signature
