* Markus Armbruster (arm...@redhat.com) wrote: > Marc-André Lureau <marcandre.lur...@redhat.com> writes: > > > This option does nothing since commit 06ac27f. Deprecate it. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > vl.c | 11 +++-------- > > include/monitor/monitor.h | 2 +- > > qemu-options.hx | 8 ++++---- > > 3 files changed, 8 insertions(+), 13 deletions(-) > > > > v2: > > - update after Markus review > > - fix error on default monitor > > - drop from qemu-trivial > > Suggest to squash in the appended patch. > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > > Could go via David, Paolo or myself. David, do you have anything > pending right now?
I don't have anything pending at the moment; but I could take it; it doesn't seem especially urgent. Dave > > > diff --git a/monitor.c b/monitor.c > index b07f254..ab9e911 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4093,7 +4093,7 @@ QemuOptsList qemu_mon_opts = { > .name = "chardev", > .type = QEMU_OPT_STRING, > },{ > - .name = "default", > + .name = "default", /* deprecated */ > .type = QEMU_OPT_BOOL, > },{ > .name = "pretty", -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK