no-re...@patchew.org writes: > Checking PATCH 3/4: target-ppc: implement xxbr[qdwh] instruction... > ERROR: Macros with complex values should be enclosed in parenthesis > #173: FILE: target-ppc/translate/vsx-ops.inc.c:42: > +#define GEN_XX2FORM_EO(name, opc2, opc3, opc4, fl2) > \ > +GEN_HANDLER2_E_2(name, #name, 0x3C, opc2 | 0, opc3, opc4, 0, PPC_NONE, fl2), > \ > +GEN_HANDLER2_E_2(name, #name, 0x3C, opc2 | 1, opc3, opc4, 0, PPC_NONE, fl2) >
Check patch doesn't like #define FOO(x) \ BAR(x), \ BAR(x+1) If I get rid of the "," the error goes away, which is not correct for this use case. It is a false positive. > total: 1 errors, 0 warnings, 156 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 4/4: target-ppc: Add xscmp[eq, gt, ge, ne]dp instructions... > === OUTPUT END === > > Test command exited with code: 1 > Regards Nikunj
