On 07/19/2016 12:15 AM, Fam Zheng wrote: > On Mon, 07/18 22:07, Eric Blake wrote: >> nbd/server.c | 78 >> +++++++++++++++++++++++++++++++++++++++++++++--------------- >> 1 file changed, 59 insertions(+), 19 deletions(-) >> >> diff --git a/nbd/server.c b/nbd/server.c >> index c8716f1..ad31c4a 100644 >> --- a/nbd/server.c >> +++ b/nbd/server.c >> @@ -235,6 +235,38 @@ static int nbd_negotiate_send_rep(QIOChannel *ioc, >> uint32_t type, uint32_t opt) >> return nbd_negotiate_send_rep_len(ioc, type, opt, 0); >> } >> >> +/* Send an error reply. >> + * Return -errno to kill connection, 0 to continue negotiation. */ >> +static int GCC_FMT_ATTR(4, 5) >> + nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type, > > Isn't the function name supposed to be place at col 0?
I blame emacs for that one. I'm (finally) back to working on this series, and will have a v6 posted soon addressing comments here and elsewhere. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
