On Tue, Oct 11, 2016 at 4:05 PM, Richard Henderson <r...@twiddle.net> wrote: > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> Signed-off-by: Artyom Tarasenko <atar4q...@gmail.com> >> --- >> target-sparc/ldst_helper.c | 51 >> ++++++++++++++-------------------------------- >> 1 file changed, 15 insertions(+), 36 deletions(-) > > > Perhaps this should be folded with patch 19. > >> +static uint64_t ultrasparc_tsb_pointer(CPUSPARCState *env, SparcV9MMU >> mmu, >> + int idx) > > > Did you really mean to pass the whole mmu structure by value? That's 16 > words that need to be copied to perform this call. I'm sure it would be > better to pass by (const?) reference.
Indeed. Thanks. -- Regards, Artyom Tarasenko SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
