On 7 October 2016 at 10:49, Daniel P. Berrange <berra...@redhat.com> wrote:
> The vhost-user code is poking at the QemuOpts instance
> in the CharDriverState struct, not realizing that it is
> valid for this to be NULL. e.g. the following crash
> shows a codepath where it will be NULL:
> +typedef enum {
> + /* Whether the chardev acts as a network server and can
> + * thus support qemu_chr_wait_connected() to wait for
> + * incoming clients */
> + QEMU_CHAR_FEATURE_NETWORK_SERVER,
> + /* Whether it is possible to send/recv file descriptors
> + * over the data channel */
> + QEMU_CHAR_FEATURE_FD_PASS,
> +
> + QEMU_CHAR_FEATURE_LAST,
> +} CharDriverFeature;
Will net/colo-compare.c need more features than this, or
will these suffice for both?
thanks
-- PMM
