On 10/04/2016 11:27 AM, Peter Maydell wrote: > The quiet-command make rule currently takes two arguments: > the command and arguments to run, and a string to print if > the V flag is not set (ie we are not being verbose). > By convention, the string printed is of the form > " NAME some args". Unfortunately to get nicely lined up > output all the strings have to agree about what column the > arguments should start in, which means that if we add a > new quiet-command usage which wants a slightly longer CMD > name then we either put up with misalignment or change > every quiet-command string. >
> > Changes v1->v2: > * rebased on master, one new use of quiet-command updated > * in pc-bios/optionrom/Makefile and pc-bios/s390-ccw/Makefile, > use "BUILD" and "SIGN" for consistency (and to avoid 8-letter word) > * improved consistency somewhat by not putting spaces after > comma before "THING" strings > * tidy "LD -r" printed for .mo link to plain "LD" I reviewed the interdiff between v1 and v2, and am satisfied enough to add: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
