On Wed, Sep 28, 2016 at 02:08:05PM +0100, Daniel P. Berrange wrote: > If there is a double underscore in an event name, at least > systemtap 3.0 will turn that into a single underscore. This > in turn breaks the generated QEMU code that calls this > event. The generated-tracers.h file calls a macro called > QEMU_SPAPR_VSCSI__PROCESS_LOGIN, but the corresponding > generated-tracers-dtrace.h file defines a macro called > QEMU_SPAPR_VSCSI_PROCESS_LOGIN. > > It is unclear if this removal of double underscores is > intended behaviour of systemtap or not. So rather than > try to change the tracetool to generate the systemtap > macro with the double underscore squished, it is > simpler to just avoid this usage in the first place. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
