On 09/30/2016 12:34 PM, Peter Maydell wrote: >>>> + bool iss_sf = opc == 0 ? false : true;
Feels like a double negative. >>> >>> You could simplify that to: >>> >>> bool iss_sf = !(opc == 0); >> >> I don't really see how that is simpler/clearer. >> >> I considered: >> bool iss_sf = opc != 0; Or even shorter: bool iss_sf = !opc; -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
