Hi Peter, On 22/09/2016 17:59, Peter Maydell wrote: > On 22 September 2016 at 16:53, Auger Eric <eric.au...@redhat.com> wrote: >> Hi Peter, >> >> On 22/09/2016 17:03, Peter Maydell wrote: >>> Also, I think it would be simpler to just have kvm_its_send_msi() do >>> >>> if (unlikely(!s->translater_gpa_known)) { >>> s->gits_translater_gpa = ...; >>> s->translater_gpa_known = true; >>> } >> My issue precisely is to get the absolue GPA of the ITS translater. >> kvm_its_send_msi is called by the region write callback which works on >> relative address wrt start of the translation region while kvm ioctl >> uses the absolute GPA. I did not see any other way to retrieve the >> absolute GPA than using a machine init done notifier. > > I don't understand. There should be no difference between > (1) calculate gits_translater_gpa in the machine init done notifier > (2) calculate gits_translater_gpa the first time that we need it, > ie on first call to kvm_its_send_msi() > > We don't use it anywhere else, do we ? Oh yes I now understand. Indeed I have all the data needed from kvm_its_send_msi parameters to compute it there. At the moment we do not use it anywhere else.
I will proceed that way then. Thanks Eric > > thanks > -- PMM >