On 22 September 2016 at 16:53, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> These changes mean the code is now doing bitwise-logic on >> bool variables, for instance: >> s->busy &= s->enabled; > >> We also assign '0' and '1' to them rather than 'true' and 'false'. > > Yes, I went through and as far as I can tell they're always > used as booleans already.
Yeah, but using bitwise ops on booleans is the kind of thing that prompts compilers and static analysers and linters to complain, so we should fix those expressions if we're changing the type. thanks -- PMM
