Daniel P Berrange writes: > On Thu, Sep 22, 2016 at 02:35:38PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: [...] >> > diff --git a/scripts/tracetool/format/events_h.py >> > b/scripts/tracetool/format/events_h.py >> > index 80a66c5..5da1d4c 100644 >> > --- a/scripts/tracetool/format/events_h.py >> > +++ b/scripts/tracetool/format/events_h.py >> > @@ -29,27 +29,15 @@ def generate(events, backend): >> > out('extern TraceEvent %(event)s;', >> > event = e.api(e.QEMU_EVENT)) >> >> > - # event identifiers >> > - out('typedef enum {') >> > - >> > - for e in events: >> > - out(' TRACE_%s,' % e.name.upper()) >> > - >> > - out(' TRACE_EVENT_COUNT', >> > - '} TraceEventID;') >> > - >> > for e in events: >> > out('extern uint16_t %s;' % e.api(e.QEMU_DSTATE)) >> >> > - # per-vCPU event identifiers >> > - out('typedef enum {') >> > - >> > + numvcpu = 0 >> > for e in events: >> > if "vcpu" in e.properties: >> > - out(' TRACE_VCPU_%s,' % e.name.upper()) >> > + numvcpu += 1 >> >> > - out(' TRACE_VCPU_EVENT_COUNT', >> > - '} TraceEventVCPUID;') >> >> Here's a more pythonic way to write it: >> >> numvcpu = len([e for e in events if "vcpu" in e.properties])
> FWIW I was tending to avoid this kind of idiom, since most of QEMU > maintainers are C developers, for whom this looks rather alien. I dont wanna enter into a coding style discussion, since I don't know how alien QEMU developers feel about this (to me, it certainly looks ugly to keep the explicit for loop). Feel free to ignore it. Cheers, Lluis