On 09/21/2016 03:10 PM, Marc-André Lureau wrote: > Missing argument returns a corresponding error message for all types > now. > > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for > argument structure members (it returned QERR_INVALID_PARAMETER). Only > for top-level argument it did return QERR_MISSING_PARAMETER. It is > preferable to have a consistent error for missing fields in inner > structs as well. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > --- > tests/qemu-iotests/087.out | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Yes, this looks better. If the message is changed earlier in this series, then this should be squashed into that patch (3/4?); if the message changed as the result of an earlier commit, the commit message should call out the id at which the tree was temporarily broken. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
