On Tue, Sep 06, 2016 at 04:43:00AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2016 at 08:56:44PM +0200, Lluís Vilanova wrote: > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > > index 929ec2f..8973f57 100644 > > --- a/include/hw/pci/pci.h > > +++ b/include/hw/pci/pci.h > > @@ -80,6 +80,8 @@ > > #define PCI_DEVICE_ID_VIRTIO_RNG 0x1005 > > #define PCI_DEVICE_ID_VIRTIO_9P 0x1009 > > > > +#define PCI_DEVICE_ID_HYPERTRACE 0x10f0 > > + > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > #define PCI_DEVICE_ID_REDHAT_BRIDGE 0x0001 > > #define PCI_DEVICE_ID_REDHAT_SERIAL 0x0002 > > > There's no need to add IDs to this header. > We should probably drop the ones we currently have in pci.h, too.
Defining the PCI IDs in public headers gives libqos test cases access to them. If they are scoped to only be available in device emulation code then the test cases need to duplicate them, which is undesirable IMO. Stefan
signature.asc
Description: PGP signature
