On 13/09/2016 11:20, Daniel P. Berrange wrote: >> > +typedef struct CryptoPacket CryptoPacket; >> > +typedef struct CryptoQueue CryptoQueue; >> > +typedef struct CryptoPacketBuf CryptoPacketBuf; >> > + >> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); > As previously, I'd expect naming of > > QCryptoCryptodevPacket > QCryptoCryptodevPacketBuf > QCryptoCryptodevQueue >
Gonglei, you are copying a lot of code from network backends. I am not sure why you would need a queue for virtio-crypto rather than a direct connection between frontend and backend (and the backend would be QEMU crypto APIs, like Daniel suggested). Paolo
