On Mon, Sep 12, 2016 at 06:20:36PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" <berra...@redhat.com> writes: > > > The QmpOutputVisitor has no direct dependancy on QMP. It is > > valid to use it anywhere that one wants a QObject. Rename it > > to better reflect its functionality as a generic QAPI > > to QObject convertor. > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > block/qapi.c | 4 +- > > blockdev.c | 4 +- > > docs/qapi-code-gen.txt | 2 +- > > ...p-output-visitor.h => qobject-output-visitor.h} | 10 +- > > qapi/Makefile.objs | 2 +- > > qapi/qapi-clone-visitor.c | 2 +- > > qapi/qmp-output-visitor.c | 256 > > --------------------- > > qapi/qobject-output-visitor.c | 254 > > ++++++++++++++++++++ > > qemu-img.c | 8 +- > > qom/object_interfaces.c | 2 +- > > qom/qom-qobject.c | 4 +- > > scripts/qapi-commands.py | 4 +- > > scripts/qapi-event.py | 4 +- > > tests/.gitignore | 2 +- > > tests/Makefile.include | 8 +- > > tests/check-qnull.c | 4 +- > > ...put-visitor.c => test-qobject-output-visitor.c} | 4 +- > > tests/test-string-output-visitor.c | 2 +- > > tests/test-visitor-serialization.c | 4 +- > > util/qemu-sockets.c | 2 +- > > 20 files changed, 290 insertions(+), 292 deletions(-) > > rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} > > (66%) > > delete mode 100644 qapi/qmp-output-visitor.c > > create mode 100644 qapi/qobject-output-visitor.c > > rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} > > (99%) > > $ git-grep -Ei 'qmp.?output.*?vis' > tests/test-qobject-output-visitor.c: * QMP Output Visitor unit-tests.
Yep, will fix that. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|