On Mon, Sep 12, 2016 at 11:17:37AM +1000, David Gibson wrote: [...]
> > I think now I understand the point... Then I'd prefer to use David's > > suggestion. A single notify_changed() looks cleaner. To be more > > explicit, I would prefer to rename it to notifier_flag_changed(), > > since notify_changed() looks like to be called every time notifier > > list changed, but actually it is for monitoring the flags. > > That sounds reasonable. I think notifier_flag_changed() should be > passed both the old and new flags, to save the backend having to keep > track of the old ones - which flags have changed might affect what the > callback needs to do. Agree. That's exactly what v4 was doing. Thanks, -- peterx
