On 08.09.2016 00:32, Eric Blake wrote: > On 09/07/2016 08:22 AM, Dmitry Osipenko wrote: >> Ptimer is a generic countdown timer helper that is used by many timer >> device models as well as by the QEMU core. Add QTests for the ptimer. >> >> Signed-off-by: Dmitry Osipenko <dig...@gmail.com> >> --- > >> --- /dev/null >> +++ b/tests/ptimer-test-stubs.c >> @@ -0,0 +1,107 @@ >> +/* >> + * Stubs for the ptimer-test >> + * >> + * Author: Dmitry Osipenko <dig...@gmail.com> >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. >> + * See the COPYING file in the top-level directory. >> + * > > I'm not a lawyer, but my reading of the GPL says that for it to be > enforceable, someone has to claim copyright (in other words, it works > BECAUSE of copyright law). Yeah, you may already have implicit rights > based on country of origin, but it's always safer to add an explicit > Copyright line; if for no other reason than to be consistent with what > most other files do. >
Thank you for the suggestion, I'll s/Author:/Copyright (C) 2016,/. The consistency with other files is arguable, because that variant I choose by looking in several files and picking the most popular. > Also, are these new files covered by an addition to MAINTAINERS? > No, they are not. Not every file in tests/ covered by MAINTAINERS, get_maintainer script returns sane suggestion for them based on the recent contributors. -- Dmitry
