Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2] qqq: module for synchronizing with a
simulation clock
Type: series
Message-id: 1473196195-9388-1-git-send-email-nutar...@ornl.gov
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
88bc925 qqq: module for synchronizing with a simulation clock
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qqq: module for synchronizing with a simulation clock...
ERROR: do not initialise statics to 0 or NULL
#140: FILE: qqq.c:16:
+static int elapsed = 0;
ERROR: "foo* bar" should be "foo *bar"
#201: FILE: qqq.c:77:
+static void fd_read(void* opaque)
ERROR: trailing whitespace
#206: FILE: qqq.c:82:
+} $
ERROR: space required after that ',' (ctx:VxV)
#222: FILE: qqq.c:98:
+ qemu_set_fd_handler(read_fd,fd_read,NULL,NULL);
^
ERROR: space required after that ',' (ctx:VxV)
#222: FILE: qqq.c:98:
+ qemu_set_fd_handler(read_fd,fd_read,NULL,NULL);
^
ERROR: space required after that ',' (ctx:VxV)
#222: FILE: qqq.c:98:
+ qemu_set_fd_handler(read_fd,fd_read,NULL,NULL);
^
ERROR: line over 90 characters
#317: FILE: vl.c:2973:
+ QemuOpts *hda_opts = NULL, *opts, *machine_opts, *icount_opts = NULL,
*qqq_opts = NULL;
ERROR: Missing Signed-off-by: line(s)
total: 8 errors, 0 warnings, 304 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
