On Tue, Sep 06, 2016 at 08:59:58AM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH] test: add drive-mirror qtest > Type: series > Message-id: 1473170519-72598-1-git-send-email-wangji...@huawei.com >
Hi Jie, Thanks for the patch. You can check for this sort of issue by running the 'checkpatch.pl' utility on your patches, prior to submission... e.g.: ./scripts/checkpatch.pl patchfilename.patch Also, when submitting a new patch revision, it should be indicated in the subject line, e.g.: [PATCH v2] test: add drive-mirror qtest Regarding the patch itself, is there something this does that is not covered in the io-test case 041 (tests/qemu-iotest/041)? Thanks, Jeff > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/1473170519-72598-1-git-send-email-wangji...@huawei.com -> > patchew/1473170519-72598-1-git-send-email-wangji...@huawei.com > * [new tag] > patchew/1473171997-11359-1-git-send-email-berra...@redhat.com -> > patchew/1473171997-11359-1-git-send-email-berra...@redhat.com > * [new tag] > patchew/1473173750-11761-1-git-send-email-mar...@redhat.com -> > patchew/1473173750-11761-1-git-send-email-mar...@redhat.com > Switched to a new branch 'test' > d44ab2b test: add drive-mirror qtest > > === OUTPUT BEGIN === > Checking PATCH 1/1: test: add drive-mirror qtest... > ERROR: do not set execute permissions for source files > #31: FILE: tests/drive-mirror-test.c > > total: 1 errors, 0 warnings, 111 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org
