On 21 July 2016 at 15:31, Dmitry Osipenko <dig...@gmail.com> wrote: > Hello, > > Currently, QEMU ARM MPTimer device model provides only a certain subset of > the emulation behavior. This patch series is supposed to add missing parts by > converting the MPTimer to use generic ptimer helper. It fixes some important > ptimer bugs and provides new features that are required for the ARM MPTimer. > > Changelog: > V15: As per Peter's Maydell request: split ptimer policy patches, > so that first "policy" patch only sets default policy to all > of the timers without introducing new behaviour policies. > > The "deferred trigger" ptimer policy from V14 is converted to > "continuous trigger" as it is more intuitive. > > New ptimer policies added. > > New ptimer patch "Actually stop timer in case of error". > > Fixed ARM MPTimer periodic/oneshot "on the fly" mode switch > for the case when load = 0 and new mode has prescaler = 0. > > Added QTests for each of the ptimer policies. > > Added QTests for the ARM MPTimer. > > V14: Set the ptimer policy in the ptimer_init() instead of adding > ptimer_set_policy(), keeping ptimer VMState unchanged and dropped > hw_error() hardening asserts as per Peter's Maydell V13 review > comments, addressed the rest of the review comments. > > Dmitry Osipenko (15): > hw/ptimer: Change ptimer_get_count to return "1" for the expired timer > hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active > timer > hw/ptimer: Actually stop timer in case of error > hw/ptimer: Introduce timer policy feature > tests: Add ptimer tests > hw/ptimer: Add "wraparound after one period" policy > tests: ptimer: Add tests for "wraparound after one period" policy > hw/ptimer: Add "continuous trigger" policy > tests: ptimer: Add tests for "continuous trigger" policy > hw/ptimer: Add "no immediate trigger" policy > tests: ptimer: Add tests for "no immediate trigger" policy > hw/ptimer: Add "no immediate reload" policy > tests: ptimer: Add tests for "no immediate reload" policy > arm_mptimer: Convert to use ptimer > tests: Add tests for the ARM MPTimer
I tried "check this compiles and passes the tests for each commit", and what I found was that you get a lot of new warnings running 'make check' about "Timer with period zero, disabling", which were not there before. Could you look into this and fix it, please? thanks -- PMM
