Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] linux-user: Use correct offset of tuc_stack in 
ARM do_sigframe_return_v2
Type: series
Message-id: 1472934496-30873-1-git-send-email-t.e.baldwi...@members.leeds.ac.uk

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1472934496-30873-1-git-send-email-t.e.baldwi...@members.leeds.ac.uk -> 
patchew/1472934496-30873-1-git-send-email-t.e.baldwi...@members.leeds.ac.uk
Switched to a new branch 'test'
efaada2 linux-user: Use correct offset of tuc_stack in ARM do_sigframe_return_v2

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: Use correct offset of tuc_stack in ARM 
do_sigframe_return_v2...
ERROR: line over 90 characters
#22: FILE: linux-user/signal.c:2065:
+    if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v2, 
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)

ERROR: braces {} are necessary for all arms of this statement
#22: FILE: linux-user/signal.c:2065:
+    if (do_sigaltstack(frame_addr + offsetof(struct rt_sigframe_v2, 
uc.tuc_stack), 0, get_sp_from_cpustate(env)) == -EFAULT)
[...]

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

Reply via email to