On (Wed) 03 Aug 2016 [20:25:40], zhanghailiang wrote: > We add helper function colo_supported() to indicate whether > colo is supported or not, with which we use to control whether or not > showing 'x-colo' string to users, they can use qmp command > 'query-migrate-capabilities' or hmp command 'info migrate_capabilities' > to learn if colo is supported. > > Cc: Juan Quintela <quint...@redhat.com> > Cc: Amit Shah <amit.s...@redhat.com> > Cc: Eric Blake <ebl...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
> +#include "qemu/osdep.h" > +#include "migration/colo.h" > + > +bool colo_supported(void) > +{ > + return true; > +} Can you start with this disabled, and returning true when all the pieces are done (ie close to the patches when the functionality is actually useful later in the series?).